Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support meta at config level for metric nodes #9580

Merged
merged 1 commit into from
Feb 16, 2024
Merged

support meta at config level for metric nodes #9580

merged 1 commit into from
Feb 16, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 15, 2024 •
edited
Loading

resolves #9441

Problem

meta is not supported under configs for Metric nodes. It is only supported as the top level attribute. This is deprecated behavior and it needs to be supported at the config level.

Solution

Support meta at the config level while also maintaining backwards compatibility for meta at the metric level.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 15, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2411f93) 87.97% compared to head (f10050a) 87.92%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9580      +/-   ##
==========================================
- Coverage   87.97%   87.92%   -0.06%     
==========================================
  Files         167      168       +1     
  Lines       22171    22211      +40     
==========================================
+ Hits        19506    19530      +24     
- Misses       2665     2681      +16
Flag Coverage Δ
integration 85.51% <100.00%> (-0.13%) ⬇️
unit 61.92% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Feb 16, 2024
@emmyoop emmyoop marked this pull request as ready for review February 16, 2024 13:42
@emmyoop emmyoop requested a review from a team as a code owner February 16, 2024 13:42
@emmyoop emmyoop requested review from aranke and QMalcolm February 16, 2024 13:42
QMalcolm
QMalcolm approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🚀

@emmyoop emmyoop merged commit 6965eca into main Feb 16, 2024
60 of 62 checks passed
@emmyoop emmyoop deleted the er/9441-metric-meta branch February 16, 2024 15:27
@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Feb 16, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4945

@Jstein77 Jstein77 added this to the v1.8 milestone Feb 20, 2024
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

@aranke aranke Awaiting requested review from aranke aranke is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Nest Metric node meta under config
4 participants
@emmyoop @FishtownBuildBot @QMalcolm @Jstein77